Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more log and metrics for instance plan cache eviction #55377

Merged
merged 3 commits into from
Aug 13, 2024
Merged

planner: add more log and metrics for instance plan cache eviction #55377

merged 3 commits into from
Aug 13, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: add more log and metrics for instance plan cache eviction

What changed and how does it work?

  1. add more log and metrics for instance plan cache eviction
  2. prevent updating instance plan cache items during eviction
  3. update the default eviction interval from 15s to 30s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 13, 2024
@tiprow tiprow
Copy link

tiprow bot commented Aug 13, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.4994%. Comparing base (1f40cb0) to head (9f7e503).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #55377        +/-   ##
================================================
+ Coverage   74.9319%   75.4994%   +0.5675%     
================================================
  Files          1575       1578         +3     
  Lines        365334     443158     +77824     
================================================
+ Hits         273752     334582     +60830     
- Misses        71872      88061     +16189     
- Partials      19710      20515       +805
Flag Coverage Δ
integration 49.6473% <58.0645%> (?)
unit 72.1817% <80.6451%> (-1.7110%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 60.0881% <ø> (+12.4147%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 13, 2024

/retest

@tiprow tiprow
Copy link

tiprow bot commented Aug 13, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qw4990 qw4990 mentioned this pull request Aug 13, 2024
Merged
13 tasks
AilinKid
AilinKid reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-13 03:35:36.487352087 +0000 UTC m=+239021.190821728: ☑️ agreed by hawkingrei.
  • 2024-08-13 07:00:53.929592434 +0000 UTC m=+251338.633062076: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 13, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 13, 2024

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Aug 13, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 594d02a into pingcap:master Aug 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@AilinKid AilinKid AilinKid approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @hawkingrei @AilinKid @tangenta